Fix audit_log not generated for disruptive actions #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@victorhora I have a strong feeling that we need tests here. Logging is clearly a PITA-point in the connector part as well, so having broader test coverage here will be a great benefit. |
|
Can confirm this PR does work, been testing it in my sandbox environments. |
|
@victorhora Merging this. It will be very good to have the tests as @defanator suggests. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intended to fix issues #170, owasp-modsecurity/ModSecurity/issues/2220 and owasp-modsecurity/ModSecurity/issues/2237 where the audit_log audit_log not generated for disruptive actions.
This changes commit baef88a that fixes the custom error pages issue (owasp-modsecurity/ModSecurity#2143) but it seemed to be returning too early not allowing the audit_logs to be generated on all phases.